Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs styles #182

Closed
wants to merge 1 commit into from
Closed

Tabs styles #182

wants to merge 1 commit into from

Conversation

evgenoid
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Issue Number: GOOD-168

Does this PR introduce a breaking change?

[ ] Yes
[x] No
Screenshot 2024-05-14 at 15 24 08 Screenshot 2024-05-14 at 15 24 18

@evgenoid evgenoid self-assigned this May 14, 2024
@netlify Netlify
Copy link

netlify bot commented May 14, 2024 •
edited
Loading

✅ Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit 64b554f
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/66435863ab69d80008733080
😎 Deploy Preview https://deploy-preview-182--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amcdnl amcdnl requested a review from ghsteff May 14, 2024 13:39
@evgenoid
Copy link
Contributor Author

@ghsteff what we decided with this one?

@ghsteff
Copy link
Contributor

ghsteff commented May 17, 2024

@ghsteff what we decided with this one?

So the tertiary tab variant looks pretty much the same as our button group which could be confusing if you use both of these in the same app. But this is a nice variant of tab to have pre-built 🤔

You know how we have some stories called CustomTheme? Maybe having this tertiary tab variant as a CustomTheme story would make the most sense because it's saying "This doesn't necessarily match our default theme, but it's one example of a way you could style this"

You think some designs would use all these tab variants in one app?

amcdnl
amcdnl reviewed Jun 4, 2024
View reviewed changes
src/layout/Tabs/Tab.tsx
/**
* The variant of the tab.
*/
variant?: 'text' | 'button';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats this for ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have two different styles in figma:
image
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And thats set internally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for tertiary tabs variant

@amcdnl amcdnl closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcdnl amcdnl amcdnl left review comments

@steppy452 steppy452 Awaiting requested review from steppy452

@SerhiiTsybulskyi SerhiiTsybulskyi Awaiting requested review from SerhiiTsybulskyi

@ghsteff ghsteff Awaiting requested review from ghsteff

Assignees

@evgenoid evgenoid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evgenoid @ghsteff @amcdnl